From f28b218e97acec8935c0c868863a9f4b6a061a39 Mon Sep 17 00:00:00 2001
From: fxbrit <fxbrit@tuta.io>
Date: Tue, 11 Jan 2022 01:21:10 +0100
Subject: [PATCH] now users can pick whatever language for the UI

---
 docs/Changelog.md | 26 ++++++++++++++++++++++++++
 librewolf.cfg     | 18 +++++++-----------
 2 files changed, 33 insertions(+), 11 deletions(-)

diff --git a/docs/Changelog.md b/docs/Changelog.md
index a923462..cfeba76 100644
--- a/docs/Changelog.md
+++ b/docs/Changelog.md
@@ -1,6 +1,32 @@
 This changelog will be used from now on to document changes in a precise manner, with a list of changes for each setting version.
 Setting versions are documented using the pref `librewolf.cfg.version`, available in about:config.
 
+## 5.1
+
+**target commit**:
+
+**base librewolf version**: 96.x
+
+**References**:
+- [fix language issue](https://gitlab.com/librewolf-community/settings/-/issues/125)
+
+#### Added preferences
+```
+pref("intl.accept_languages", "en-US, en");
+```
+
+#### Removed preferences
+```
+defaultPref("intl.locale.requested", "en-US");
+defaultPref("browser.search.region", "US"); // set a default search region for all users
+defaultPref("extensions.getAddons.langpacks.url", ""); // prevent users from adding lang packs, which would cause leaks
+```
+
+#### Changed preferences
+```
+pref("javascript.use_us_english_locale", true);
+```
+
 ## 5.0
 
 **target commit**: from 8a98176400e2e44ae1138ea8bdc1991250f75b8e to b219a75b4a0d72b519ce386406f45acead940c9a
diff --git a/librewolf.cfg b/librewolf.cfg
index cf2db19..407db86 100755
--- a/librewolf.cfg
+++ b/librewolf.cfg
@@ -9,7 +9,7 @@
  
  */
 
-defaultPref("librewolf.cfg.version", "5.0");
+defaultPref("librewolf.cfg.version", "5.1");
 
 // -------------------------------
 // # SANITIZING, TP, SESSIONS
@@ -241,9 +241,12 @@ lockPref("geo.provider.ms-windows-location", false); // [WINDOWS]
 lockPref("geo.provider.use_corelocation", false); // [MAC]
 lockPref("geo.provider.use_gpsd", false); // [LINUX]
 
-// show language as en-US for all users, regardless of their OS language and local version, to avoid leaking
-defaultPref("javascript.use_us_english_locale", true);
-defaultPref("intl.locale.requested", "en-US");
+/**
+show language as en-US for all users, regardless of their OS language and browser language.
+must use pref and not defaultPref to work. spoof_english also sets the UI correctly.
+ */
+pref("javascript.use_us_english_locale", true);
+pref("intl.accept_languages", "en-US, en");
 defaultPref("privacy.spoof_english", 2);
 
 // disable region updates
@@ -265,7 +268,6 @@ lockPref("browser.urlbar.suggest.quicksuggest.nonsponsored", false); // disable
 lockPref("browser.urlbar.suggest.quicksuggest.sponsored", false); // disable sponsored suggestions
 lockPref("browser.urlbar.quicksuggest.dataCollection.enabled", false); // default
 
-defaultPref("browser.search.region", "US"); // set a default search region for all users
 defaultPref("browser.search.update", false); // do not update open search search engines
 defaultPref("browser.urlbar.trimURLs", false); // do not trim urls in the urlbar
 
@@ -328,12 +330,6 @@ defaultPref("extensions.enabledScopes", 5); // hidden
 
 defaultPref("extensions.postDownloadThirdPartyPrompt", false); // force install prompt for thrid party extensions 
 
-/**
- prevent users from adding lang packs, which would cause leaks.
- default is https://services.addons.mozilla.org/api/v3/addons/language-tools/?app=firefox&type=language&appversion=%VERSION%
-*/
-defaultPref("extensions.getAddons.langpacks.url", "");
-
 // about:addons ui
 defaultPref("extensions.htmlaboutaddons.recommendations.enabled", false); // disable recommendations from addons list
 defaultPref("extensions.getAddons.showPane", false); // disable recommendations section