Use the new resources from the common submodule

KNOWN_ISSUES.md

@@ -3,9 +3,10 @@ Known Issues (2021-02-07)
 
 These issues are already reported, and sorted by priority:
 
-* Help > About LibreWolf: It is broken and is unreadable. ([issue #11](https://gitlab.com/librewolf-community/browser/windows/-/issues/11))
+* about:addons search not working (use [https://addons.mozilla.org/](https://addons.mozilla.org/) directly) ([issue #16](https://gitlab.com/librewolf-community/browser/windows/-/issues/16))
+* Unable to set as default browser ([issue #15](https://gitlab.com/librewolf-community/browser/windows/-/issues/15))
 * Automation builds. This seems to be a possibility mentioned [here](https://firefox-source-docs.mozilla.org/setup/windows_build.html#building-firefox-on-windows). ([issue #6](https://gitlab.com/librewolf-community/browser/windows/-/issues/6))
-* Is there any way to update? ([issue #12](https://gitlab.com/librewolf-community/browser/windows/-/issues/12))
+* Is there any way to update? (no, not soon) ([issue #12](https://gitlab.com/librewolf-community/browser/windows/-/issues/12))
 * Previous session tabs, doesn't restoring after restart, although option is enabled in settings. ([issue #11](https://gitlab.com/librewolf-community/browser/windows/-/issues/11))
 * There some issue with rendering. All looks a bit blurred, or if there no smoothing enabled. ([issue #11](https://gitlab.com/librewolf-community/browser/windows/-/issues/11))
 * Choosing a bookmark inside an empty tab loads the page in the same tab, else, if the tab is not empty, it loads in a new tab. Right-clicking on the bookmark, and selecting "Open" (which is bold) from the context menu correctly opens the link in the same tab. Essentially, unless the tab is empty, left-clicking on a link behaves as if middle-mouse-clicking on a link. ([issue #11](https://gitlab.com/librewolf-community/browser/windows/-/issues/11))
@@ -25,4 +26,11 @@ The following issues are not considered windows-specific:
 The following issues are considered closed:
 
 * [issue #2](https://gitlab.com/librewolf-community/browser/windows/-/issues/2)
-* [issue #4](https://gitlab.com/librewolf-community/browser/windows/-/issues/4)
+* [issue #4](https://gitlab.com/librewolf-community/browser/windows/-/issues/4)
+
+These don't have their own issue yet:
+
+* IPV6 issues, it's not working properly?
+* problem with old sed. does not recognize -z. using the one from Git might be a work around.
+* What IP address does LW show on my sb site, and why does it show anything at all when Bing does show the ip address of my nginx? what header stuff is going on?
+* why does this anoying thing happen to my 'copy username' menu in lastpass (the local menu shows up)

TODO.md

@@ -1,55 +0,0 @@
-Things to do:
--------------
-
-These are ordered by priority:
-
-* IPV6 issues, it's not working properly?
-* Create an HOW_TO_BUILD.md to contain better, detailed instructions on how to build.
-* Branding issues. We're going to need an MR with [LibreWolf / Browser / Common](https://gitlab.com/librewolf-community/browser/common) at some point.
-* problem with old sed. does not recognize -z. using the one from Git might be a work around.
-* What IP address does LW show on my sb site, and why does it show anything at all when Bing does show
-the ip address of my nginx? what header stuff is going on?
-* why does this anoying thing happen to my 'copy username' menu in lastpass (the local menu shows up)
-* Theme AspenGlow: why does the three buttons disapear when i use the underwater screen ctrl-shift-i / Looks like a windows issue for now.
-
-Notes on the branding issue(s):
--------------------------------
-
-* This section is just some notes.
-* Build fail on missing stubinstaller (might be a FF bug as it should just take missing
-stuff from the nightly branding folder?)
-
-```
-$ mkdir stubinstaller
-$ cp bgstub.jpg stubinstaller
-$ pwd
-/c/mozilla-source/firefox-85.0/browser/branding/librewolf
-$
-
-* checking all the different files in nightly and librewolf
-
-$ cd nightly
-$ find . | sort > /c/mozilla-source/branding-nightly.txt
-$ cd ../librewolf/
-$ find . | sort > /c/mozilla-source/branding-librewolf.txt
-
-
-$ diff branding-nightly.txt branding-librewolf.txt
-4a5,6
-> ./bgstub.jpg
-> ./bgstub_2x.jpg
-7a10
-> ./content/about-background.png
-9,10d11
-< ./content/about-logo.svg
-< ./content/about-logo@2x.png
-14,15d14
-< ./content/aboutlogins.svg
-< ./content/firefox-wordmark.svg
-22,24d20
-< ./default22.png
-< ./default24.png
-< ./default256.png
-$
-```
-

build.sh

@@ -121,20 +121,11 @@ END
     sed "$_settings_services_sed" -i toolkit/components/search/SearchUtils.jsm
 
 
-
+    # copy branding resources
     cp -r ../common/source_files/* ./
 
-    # FIXME: this 'mozconfig' file in the 'common' submodule should be removed
-    # this submodule is purely for the branding. (not removing this breaks the build)
-    rm -f mozconfig
-
-    # FIXME: on windows: the stubinstaller folder is missing from the librewolf branding folder.
-    # this might be a bug in FF however as it seems to take missing branding resources from
-    # the nightly branding. We probably want this stuff merged into the 'common' submodule.
-    cp -r ../missing_branding_files/* browser/branding/librewolf
-
     # just a straight copy for now..
-    cp ../mozconfig .mozconfig
+    cp ../mozconfig .
 
     cd ..
 }

installer_win.sh

@@ -111,7 +111,7 @@ END
 pushd ..
  rm -vrf librewolf
  unzip librewolf-$pkgver.en-US.win64.zip
- cp -v missing_branding_files/firefox.ico librewolf/librewolf.ico
+ cp -v common/source_files/browser/branding/librewolf/firefox.ico librewolf/librewolf.ico
  makensis-3.01.exe installer_win.nsi
  /c/mozilla-source/Git/usr/bin/sha256sum.exe librewolf-$pkgver.en-US.win64-setup.exe > librewolf-$pkgver.en-US.win64-setup.exe.sha256sum
 popd

missing_branding_files/content/aboutDialog.css

@@ -1,54 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-#aboutDialogContainer {
-  background-image: url("chrome://branding/content/about-background.png");
-  background-repeat: no-repeat;
-  background-color: #00acff;
-  color: #090909;
-}
-
-/*
-firefox-85.0/browser/base/content/aboutDialog.css
-firefox-85.0/browser/base/content/aboutDialog.js
-firefox-85.0/browser/base/content/aboutDialog.xhtml
-*/
-/* enable this below for ESR version */
-/* #release { display: inline; } */
-
-
-.text-link {
-  color: #101010 !important;
-  text-decoration: underline;
-}
-
-#rightBox {
-    /* this margin prevents text from overlapping the planet image */
-
-    background-image: none; /* getting rid of the 'Nightly' text */
-    
-    margin-left: 275px;
-    margin-top: 50px;
-    margin-right: 20px;
-    
-    min-height: 260px;
-}
-
-#bottomBox {
-    background-color: rgba(0,0,0,.7);
-    display: none;
-}
-
-#leftBox {
-    #display: none;
-#  background-image: url("chrome://branding/content/about-logo.png");
-#  background-repeat: no-repeat;
-#  background-size: 192px auto;
-#  background-position: center 20%;
-#  /* min-width and min-height create room for the logo */
-  min-width: 210px;
-  min-height: 220px;
-  margin-top: 20px;
-  margin-inline-start: 30px;
-}

missing_branding_files/pref/firefox-branding.js

@@ -1,7 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-pref("startup.homepage_welcome_url", "https://librewolf-community.gitlab.io/");
-
-

missing_branding_files/stubinstaller/installing_page.css

@@ -1,61 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-body {
-  color: white;
-}
-
-#label,
-#progress_background,
-#blurb {
-  text-align: center;
-  margin: 20px 30px;
-}
-
-#label {
-  font-size: 40px;
-  margin-top: 100px;
-  margin-bottom: 20px;
-}
-
-#progress_background {
-  margin: 0 auto;
-  width: 60%;
-  height: 24px;
-  background-color: white;
-}
-
-body.high-contrast #progress_background {
-  outline: solid;
-}
-
-#progress_bar {
-  margin: 0;
-  width: 0%;
-  height: 100%;
-  background-color: #00AAFF;
-}
-
-/* In high contrast mode, fill the entire progress bar with its border. */
-body.high-contrast #progress_bar {
-  /* This border should be the height of progress_background. */
-  border-top: 24px solid;
-  box-sizing: border-box;
-}
-
-/* This layout doesn't want the header or content text. */
-#header, #content {
-  display: none;
-}
-
-#blurb {
-  font-size: 20px;
-}
-
-/* The footer goes in the bottom right corner. */
-#footer {
-  position: fixed;
-  right: 50px;
-  bottom: 59px;
-}

missing_branding_files/stubinstaller/profile_cleanup_page.css

@@ -1,42 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-body {
-  color: white;
-}
-
-#header,
-#refreshCheckboxContainer,
-#refreshButtonContainer {
-  text-align: center;
-  margin-left: 40px;
-  margin-right: 40px;
-  margin-bottom: 30px;
-}
-
-#header {
-  font-size: 35px;
-  font-weight: normal;
-  margin-top: 45px;
-}
-
-#refreshCheckbox {
-  vertical-align: middle;
-}
-
-#checkboxLabel {
-  font-size: 13px;
-}
-
-#refreshButton {
-  padding: 8px 40px;
-  font-size: 15px;
-}
-
-/* The footer goes in the bottom right corner. */
-#footer {
-  position: fixed;
-  right: 50px;
-  bottom: 59px;
-}