librewolf-bot/windows
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Default browser popup #1

New issue
Closed
opened 2023-01-29 05:52:42 +00:00 by HexagonCDN · 17 comments
HexagonCDN commented 2023-01-29 05:52:42 +00:00 (Migrated from codeberg.org)
Copy link

There is this annoying popup that prevents you from clicking other buttons until you close the popup.
image

I think that instead of being on a popup, the message should be on new tab homepage instead.
image

There is this annoying popup that prevents you from clicking other buttons until you close the popup. ![image](/attachments/b74eaad2-5db6-4578-af48-2588cd052461) I think that instead of being on a popup, the message should be on new tab homepage instead. ![image](/attachments/c3522df3-a07c-46ea-ad07-5b605e9e4fb2)
ltguillaume commented 2023-01-29 14:01:03 +00:00 (Migrated from codeberg.org)
Copy link

This is default FF behavior, and can be easily circumvented by enabling a checkmark once. I don't think it's worth the trouble of rewriting FF code, which isn't the intention of LW anyway.

This is default FF behavior, and can be easily circumvented by enabling a checkmark once. I don't think it's worth the trouble of rewriting FF code, which isn't the intention of LW anyway.
HexagonCDN commented 2023-01-29 14:06:27 +00:00 (Migrated from codeberg.org)
Copy link

easily circumvented by enabling a checkmark once

@ltGuillaume I was going for a better first-time user experience.

> easily circumvented by enabling a checkmark once @ltGuillaume I was going for a better first-time user experience.
maltejur commented 2023-01-29 14:10:31 +00:00 (Migrated from codeberg.org)
Copy link

This popup shouldn't be there I think

https://codeberg.org/librewolf/source/src/branch/main/patches/ui-patches/hide-default-browser.patch

This popup shouldn't be there I think https://codeberg.org/librewolf/source/src/branch/main/patches/ui-patches/hide-default-browser.patch
ltguillaume commented 2023-01-29 14:42:32 +00:00 (Migrated from codeberg.org)
Copy link

@maltejur

This popup shouldn't be there I think

https://codeberg.org/librewolf/source/src/branch/main/patches/ui-patches/hide-default-browser.patch

I stand corrrected. Strange that it still shows then.

@maltejur >This popup shouldn't be there I think > >https://codeberg.org/librewolf/source/src/branch/main/patches/ui-patches/hide-default-browser.patch I stand corrrected. Strange that it still shows then.
maltejur commented 2023-01-29 15:01:08 +00:00 (Migrated from codeberg.org)
Copy link

@HexagonCDN does the same thing still occur in a new profile (about:profiles)?

@HexagonCDN does the same thing still occur in a new profile (about:profiles)?
HexagonCDN commented 2023-01-29 15:14:38 +00:00 (Migrated from codeberg.org)
Copy link

does the same thing still occur in a new profile (about:profiles)?

Yes, it does. It also occurs on some other devices that I installed LibreWolf on.
image

> does the same thing still occur in a new profile (about:profiles)? Yes, it does. It also occurs on some other devices that I installed LibreWolf on. ![image](/attachments/10c90555-4f19-497b-8345-69ba41b4f88c)
maltejur commented 2023-01-30 11:56:26 +00:00 (Migrated from codeberg.org)
Copy link

How did you install LibreWolf on those devices? I don't see the same behaviour in my Windows VM.

How did you install LibreWolf on those devices? I don't see the same behaviour in my Windows VM.
HexagonCDN commented 2023-01-30 13:18:22 +00:00 (Migrated from codeberg.org)
Copy link

How did you install LibreWolf on those devices?

I clicked on this button over https://librewolf.net/installation/windows/
image

Note: I do use LibreWolf-WinUpdater

> How did you install LibreWolf on those devices? I clicked on this button over https://librewolf.net/installation/windows/ ![image](/attachments/bb9ef04e-5d5a-479f-b67e-3fd619736f81) Note: I do use LibreWolf-WinUpdater
maltejur commented 2023-01-31 23:58:11 +00:00 (Migrated from codeberg.org)
Copy link

To be able to further investigate that issue I would need to reproduce it myself, which I currently can't. I have tried again in a fresh Windows VM and everything still looks fine for me.

To fix the issue for you, you could try to back up your browser profiles (%APPDATA%\librewolf\Profiles), completely remove LibreWolf from your system and reinstall it.

To be able to further investigate that issue I would need to reproduce it myself, which I currently can't. I have tried again in a fresh Windows VM and everything still looks fine for me. To fix the issue for you, you could try to back up your browser profiles (`%APPDATA%\librewolf\Profiles`), completely remove LibreWolf from your system and reinstall it.
HexagonCDN commented 2023-02-08 03:08:48 +00:00 (Migrated from codeberg.org)
Copy link

To fix the issue for you, you could try to back up your browser profiles (%APPDATA%\librewolf\Profiles), completely remove LibreWolf from your system and reinstall it.

I guess it probably won't work because it also happens on many other devices, but I will try.

> To fix the issue for you, you could try to back up your browser profiles (`%APPDATA%\librewolf\Profiles`), completely remove LibreWolf from your system and reinstall it. I guess it probably won't work because it also happens on many other devices, but I will try.
HexagonCDN commented 2023-02-08 03:13:53 +00:00 (Migrated from codeberg.org)
Copy link

I guess it probably won't work because it also happens on many other devices, but I will try.

It didn't work.

> I guess it probably won't work because it also happens on many other devices, but I will try. It didn't work.
maltejur commented 2023-02-09 18:01:54 +00:00 (Migrated from codeberg.org)
Copy link

From @fxbrit:matrix.org

looks like a broken build, aka the .cfg is not being applied

it could be a few things but common causes include:

  • user edited the .cfg and made a syntax error
  • user corrupted its profile
  • user has a software that interferes with the browser (eg. Kaspersky)
  • a broken build from us

we can exclude the first two since it occurs in a new profile and after a clean install, and given that the build works fine in a VM it must be something else

I suspect it might be an antivirus or some other software / user change that prevents the .cfg from working. both the pop-up and the "more from mozilla" stuff is hidden by prefs and we make no source code changes related (the patch maltejur linked hides the default browser UI in about:preferences)

So could you maybe check if you antivirus program is doing anything here?

From @fxbrit:matrix.org > looks like a broken build, aka the .cfg is not being applied > >it could be a few things but common causes include: > - user edited the .cfg and made a syntax error > - user corrupted its profile > - user has a software that interferes with the browser (eg. Kaspersky) > - a broken build from us > > we can exclude the first two since it occurs in a new profile and after a clean install, and given that the build works fine in a VM it must be something else > > I suspect it might be an antivirus or some other software / user change that prevents the .cfg from working. both the pop-up and the "more from mozilla" stuff is hidden by prefs and we make no source code changes related (the patch maltejur linked hides the default browser UI in about:preferences) So could you maybe check if you antivirus program is doing anything here?
HexagonCDN commented 2023-02-10 01:57:12 +00:00 (Migrated from codeberg.org)
Copy link

Oh! I do have Kaspersky Free antivirus!
image

Oh! I do have Kaspersky Free antivirus! ![image](/attachments/b701d14c-29fb-4365-b22b-887ce8d6821b)
maltejur commented 2023-02-10 12:53:51 +00:00 (Migrated from codeberg.org)
Copy link

Well then there is a high chance that this is causing your problems. We've already had issues with Kaspersky in the past. Try to add a exclusion rule for LibreWolf in Kaspersky, then run the LibreWolf installer again.

Well then there is a high chance that this is causing your problems. We've already had issues with Kaspersky in the past. Try to add a exclusion rule for LibreWolf in Kaspersky, then run the LibreWolf installer again.
👍 1
HexagonCDN commented 2023-02-20 04:07:35 +00:00 (Migrated from codeberg.org)
Copy link

@maltejur

Try to add a exclusion rule

Which protect component exclusion rule? I want to exclude at little as possible for security.
image

@maltejur > Try to add a exclusion rule Which protect component exclusion rule? I want to exclude at little as possible for security. ![image](/attachments/6e551061-9a86-4b1c-9710-302f0cf893a1)
maltejur commented 2023-03-07 22:29:32 +00:00 (Migrated from codeberg.org)
Copy link

I have no idea how Kaspersky works, but I would just add a exclusion for the whole LibreWolf folder (the one that you already selected in the screenshot) and all components.

I have no idea how Kaspersky works, but I would just add a exclusion for the whole LibreWolf folder (the one that you already selected in the screenshot) and all components.
HexagonCDN commented 2023-03-07 22:59:41 +00:00 (Migrated from codeberg.org)
Copy link

all components

That sounds risky. I think I might try trial-and-error until I find the fewest amount of components that I need to exclude.

> all components That sounds risky. I think I might try trial-and-error until I find the fewest amount of components that I need to exclude.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
old-winbuild
ltguillaume-master-patch-97571
msix
malte
win64
notice
v112.0-1
v111.0.1-1
v111.0-3
v111.0-2
v110.0-1
v109.0.1-2
v109.0-1
v108.0.2-1
v108.0.1-1
v108.0-1
v107.0.1-1
v107.0-1
v106.0.5-1
v106.0.4-1
v106.0.3-1
v106.0.2-1
v106.0.1-1
v106.0-2
v105.0.3
v105.0.2
v105.0.1
v105.0
v104.0.2-1
v104.0-1
v103.0.2-1
v103.0.1-2
v103.0.1-1
v103.0-3
v102.0.1-1
v102.0-2
v101.0.1-1
v101.0-2
v100.0.2-1
v100.0.1-1
v100.0-3
v100.0
v99.0.1.2
v99.0.1
v99.0
v98.0.2
v98.0
v97.0.2
v97.0.1
v97.0
v96.0.3
v96.0.2
v96.0.1.1
v96.0.1
v96.0-0
v95.0.2
v95.0.1
v95.0
v94.0.2.3
v94.0.2-2
v94.0.2
v94.0.1
v93.0
v92.0.1
v92.0
v91.0.2
v91.0.1
v91.0
v90.0.2-4-pexec
v90.0.2-3
v90.0.2-2-settings-pane
v90.0.2
v90.0.1
v90.0
v89.0.2
v89.0.1
v89.0
v88.0.1-2
v88.0.1
v88.0-test-release
v88.0
v87.0-4
v87.0-3
v87.0-2
v87.0
v86.0.1-1
v86.0-3
v86.0-2
v86.0-1
v86.0
v85.0.2-1
85.0.2-1
85.0.1-1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: librewolf-bot/windows#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?