Enlarge icon on Large icons view mode #3

Closed
opened 2023-03-31 02:07:07 +00:00 by HexagonCDN · 16 comments
HexagonCDN commented 2023-03-31 02:07:07 +00:00 (Migrated from codeberg.org)

When I turn on this mode,
image

LibreWolf's icon still remains small. Please enlarge it.
image

When I turn on this mode, ![image](/attachments/1f8a9db7-c036-4a46-a5d5-7c1085bc2c45) LibreWolf's icon still remains small. Please enlarge it. ![image](/attachments/f5177a66-4dac-4bc9-9ad9-ada68f25ac3c)
maltejur commented 2023-03-31 15:31:00 +00:00 (Migrated from codeberg.org)

Is this with the Microsoft Store version or the regular one?

Is this with the Microsoft Store version or the regular one?
HexagonCDN commented 2023-04-01 01:40:13 +00:00 (Migrated from codeberg.org)

The regular one

The regular one
ltguillaume commented 2023-04-10 20:46:48 +00:00 (Migrated from codeberg.org)

I believe the max. icon size included in librewolf.exe is 64x64 pixels, so that's why.

Not sure why the .exe also includes the same icon again, but with a 256x256 alternative (the logo on a piece of paper).

I believe the max. icon size included in librewolf.exe is 64x64 pixels, so that's why. Not sure why the .exe also includes the same icon again, but with a 256x256 alternative (the logo on a piece of paper).
maltejur commented 2023-04-10 22:20:02 +00:00 (Migrated from codeberg.org)

Oh yeah that could be a possible fix

Oh yeah that could be a possible fix
maltejur commented 2023-04-10 22:24:04 +00:00 (Migrated from codeberg.org)
https://codeberg.org/librewolf/bsys6/commit/e974109c5fed9dfcb4c0721f52c043c8dd39e2cf
maltejur commented 2023-04-18 19:54:52 +00:00 (Migrated from codeberg.org)

This change seems to have broken the MSIX icon. I don't really know how that is possible, maybe it also is a coincidence. I'll see what I can do there.

image

This change seems to have broken the MSIX icon. I don't really know how that is possible, maybe it also is a coincidence. I'll see what I can do there. ![image](/attachments/1274251e-0097-4120-b48f-a179d20334bf)
ltguillaume commented 2023-04-18 20:08:16 +00:00 (Migrated from codeberg.org)

Yeah there's definitely something wrong with the icon now and it has become very blurry.

Here's one that adds 128x128 and 256x256 while keeping the rest as is.

Yeah there's definitely something wrong with the icon now _and_ it has become very blurry. Here's one that adds 128x128 and 256x256 while keeping the rest as is.
maltejur commented 2023-04-18 20:08:55 +00:00 (Migrated from codeberg.org)

Here's one that adds 128x128 and 256x256 while keeping the rest as is.

I actually already did that with the icon I added.

> Here's one that adds 128x128 and 256x256 while keeping the rest as is. I actually already did that with the icon I added.
ltguillaume commented 2023-04-18 20:13:57 +00:00 (Migrated from codeberg.org)

I know, but I saw all of the sizes - when viewed at 100% - were very blurry now. Even stranger, when extracted from the .ico and seen in Explorer at 16x16, they were all jigsawy instead of smooth:

image

My icon editor says they're "32bpp packed" (which is fine for the larger ones, I think, so I did that for the 256x256, saves 200KB).

I know, but I saw all of the sizes - when viewed at 100% - were very blurry now. Even stranger, when extracted from the .ico and seen in Explorer at 16x16, they were all jigsawy instead of smooth: ![image](/attachments/08da705f-dd81-4984-a763-408befb38a1a) My icon editor says they're "32bpp packed" (which is fine for the larger ones, I think, so I did that for the 256x256, saves 200KB).
maltejur commented 2023-04-18 20:29:06 +00:00 (Migrated from codeberg.org)

Hm, the weirdest thing for me is that I really don't use that icon anywhere else than in the nsis setup, so it shouldn't do anything with the msix at all.

I know, but I saw all of the sizes - when viewed at 100% - were very blurry now. Even stranger, when extracted from the .ico and seen in Explorer at 16x16, they were all jigsawy instead of smooth:

Is that different with the origial icon that was used before?

Hm, the weirdest thing for me is that I really don't use that icon anywhere else than in the nsis setup, so it shouldn't do anything with the msix at all. > I know, but I saw all of the sizes - when viewed at 100% - were very blurry now. Even stranger, when extracted from the .ico and seen in Explorer at 16x16, they were all jigsawy instead of smooth: Is that different with the origial icon that was used before?
ltguillaume commented 2023-04-18 21:01:32 +00:00 (Migrated from codeberg.org)

Both librewolf.ico and the one embedded in librewolf.exe are unpacked.

But I don't think the packed/unpacked is the cause of this, though. Here's a fully packed LibreWolf.ico (the difference is 370KB fully unpacked vs. 30KB fully packed) and I don't see any of the issues with it that I do see with the icon from e974109c5f.

Both `librewolf.ico` and the one embedded in `librewolf.exe` are unpacked. But I don't think the packed/unpacked is the cause of this, though. Here's a fully packed `LibreWolf.ico` (the difference is 370KB fully unpacked vs. 30KB fully packed) and I don't see any of the issues with it that I do see with the icon from https://codeberg.org/librewolf/bsys6/commit/e974109c5fed9dfcb4c0721f52c043c8dd39e2cf.
maltejur commented 2023-04-19 22:45:22 +00:00 (Migrated from codeberg.org)

Okay, I guess we'll just use that new packed one from you then 17fd0d824c

Okay, I guess we'll just use that new packed one from you then https://codeberg.org/librewolf/bsys6/commit/17fd0d824c6e9557804dcbd845895bfd268ce705
maltejur commented 2023-04-19 22:47:05 +00:00 (Migrated from codeberg.org)

The msix issue also seems to just have been caused by a faulty local build from me, the new version released does not seem to have it anymore.

The msix issue also seems to just have been caused by a faulty local build from me, the new version released does not seem to have it anymore.
HexagonCDN commented 2023-04-20 00:02:55 +00:00 (Migrated from codeberg.org)

image
Nice! Thank you for your fantastic work!

![image](/attachments/ed1b9f81-199b-4fe5-9594-c9559694e885) Nice! Thank you for your fantastic work!
ltguillaume commented 2023-06-15 12:57:23 +00:00 (Migrated from codeberg.org)

Do you guys also see this in the file properties dialog? Only there, though, nowhere else AFAIK...
image

I have no clue why, but after using leanify on the icon, these black parts are fixed:
image

Leanified version attached @maltejur

Do you guys also see this in the file properties dialog? Only there, though, nowhere else AFAIK... ![image](/attachments/6ed4b8d7-3ff3-4c3c-a5d6-beb4099bd0b8) I have no clue why, but after using [leanify](https://github.com/JayXon/Leanify) on the icon, these black parts are fixed: ![image](/attachments/3e695b5a-4f28-417e-b486-f29ec9bf5c49) Leanified version attached @maltejur
maltejur commented 2023-06-15 17:05:35 +00:00 (Migrated from codeberg.org)

Hm, weird. Thanks for attaching the fixed version though, I'll update the icon.

Hm, weird. Thanks for attaching the fixed version though, I'll update the icon.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: librewolf-bot/windows#3
No description provided.